Skip to content

MSI move 2018-11-30 version in stable folder#4768

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
wendyNEU:RemoveToStableFolder
Dec 5, 2018
Merged

MSI move 2018-11-30 version in stable folder#4768
jhendrixMSFT merged 1 commit intoAzure:masterfrom
wendyNEU:RemoveToStableFolder

Conversation

@wendyNEU
Copy link
Copy Markdown
Contributor

@wendyNEU wendyNEU commented Dec 4, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

autorest generate code
image

autorest validator
image

validate with oav
image

validate with OpenAPI Hub
image

@openapi-portal-comment
Copy link
Copy Markdown

openapi-portal-comment bot commented Dec 4, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3614

@wendyNEU wendyNEU closed this Dec 4, 2018
@wendyNEU
Copy link
Copy Markdown
Contributor Author

wendyNEU commented Dec 4, 2018

I found another pr already sent to move 2018-11-30 in stable folder #4743

@amarzavery amarzavery reopened this Dec 4, 2018
@openapi-portal-comment
Copy link
Copy Markdown

openapi-portal-comment bot commented Dec 4, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@amarzavery amarzavery mentioned this pull request Dec 4, 2018
Closed
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Dec 4, 2018

Can one of the admins verify this patch?

@wendyNEU
Copy link
Copy Markdown
Contributor Author

wendyNEU commented Dec 4, 2018

This pr is to move 2018-11-30 version folder to stable folder

@jhendrixMSFT jhendrixMSFT self-assigned this Dec 4, 2018
@jhendrixMSFT
Copy link
Copy Markdown
Member

jhendrixMSFT commented Dec 4, 2018

@wendyNEU just to confirm, this API version is deployed and publicly available?

@jhendrixMSFT
Copy link
Copy Markdown
Member

jhendrixMSFT commented Dec 5, 2018

OK based on comments in the original PR deployment started last month and presumably finished since Amar merged the change to master.

@jhendrixMSFT jhendrixMSFT merged commit 8aca29b into Azure:master Dec 5, 2018
@wendyNEU wendyNEU deleted the RemoveToStableFolder branch December 19, 2018 18:13
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@wendyNEU @AnuTalluri
MSI move 2018-11-30 in stable folder (Azure#4768)
193b53f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wendyNEU @AutorestCI @azuresdkci @jhendrixMSFT @amarzavery